add lib instrumentation for all Django middleware spans#4624
Open
weizhikuan wants to merge 6 commits into
Open
add lib instrumentation for all Django middleware spans#4624weizhikuan wants to merge 6 commits into
weizhikuan wants to merge 6 commits into
Conversation
Contributor
|
Hi @weizhikuan , thank you for this. Please could you fill in more details of the PR description/template? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add opt-in per-middleware span creation for Django instrumentation. When is_middleware_spans_enabled=True is passed to DjangoInstrumentor().instrument(), each middleware in settings.MIDDLEWARE produces an INTERNAL span nested under the HTTP server span. (sql commenter is intentionally ruled out from the instrumentation)
Covers all three Django middleware categories:
Async dispatch is handled: mixin middleware defers to acall when
async_mode/is_async is set; new-style call wrappers detect coroutine
returns; function factories check the inner callable.
Fixes #3723
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.